Re: [PATCH 3/5] sched/fair: Call update_curr() before unthrottling the hierarchy

From: K Prateek Nayak

Date: Mon Jun 01 2026 - 01:52:14 EST


Hello Aaron,

On 6/1/2026 9:22 AM, Aaron Lu wrote:
>> Since all callers of unthrottle_cfs_rq(), except one, already update the
>> rq_clock and call rq_clock_start_loop_update(), move the
>> update_rq_clock() in unthrottle_cfs_rq() to the lonely caller that
>> doesn't update the rq_clock.
>
> Looks like there is one more path that doesn't have clock updated:
> cpu_max_write() -> tg_set_bandwidth() -> tg_set_cfs_bandwidth() ->
> unthrottle_cfs_rq().

Woops! Completely missed that. Thank you for pointing it out. I'll
add an update_rq_clock() there too once we grab the rq_lock.

--
Thanks and Regards,
Prateek