Re: [PATCH 3/5] selftests/damon/damos_tried_regions: fix expectation output and join TypeError

[SeongJae Park]

On Sun, 31 May 2026 17:17:22 +0800 Kunwu Chan <kunwu.chan@xxxxxxxxx> wrote:

> From: Kunwu Chan <kunwu.chan@xxxxxxxxx>
> 
> The expectation print has wrong operator precedence: '%' binds
> before the conditional expression, so the else branch prints
> 'not met' without the prefix 'expectation (>= 14) is'.  Add
> parentheses to fix it.
> 
> Also, '\n'.join() on the list of ints raises TypeError;
> convert to str in the list comprehension.

Nice findings and fixes, thank you!

> 
> Co-developed-by: Wang Lian <lianux.mm@xxxxxxxxx>
> Signed-off-by: Wang Lian <lianux.mm@xxxxxxxxx>
> Signed-off-by: Kunwu Chan <chentao@xxxxxxxxxx>

checkpatch.pl may warn here like below, and it should be fixed.

WARNING: From:/Signed-off-by: email address mismatch: 'From: Kunwu Chan <kunwu.chan@xxxxxxxxx>' != 'Signed-off-by: Kunwu Chan <chentao@xxxxxxxxxx>'

Other than that,

Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>


Thanks,
SJ

[...]