Re: [PATCH net-next v3 12/14] onsemi: s2500: Add driver support for TS2500 MAC-PHY

[Andrew Lunn]

> +static void s2500_self_test(struct net_device *ndev,
> +			    struct ethtool_test *eth_test, u64 *data)
> +{

Please could you move the selftest code into another patch.  Also take
a look at net/core/selftests.c.

      Andrew