Re: [REGRESSION] Introduced double release_region in gpib/cb7210

[Greg Kroah-Hartman]

On Fri, May 29, 2026 at 07:23:14PM +0000, Dominik Karol Piątkowski wrote:
> Hi,
> 
> There are currently two patches [1][2] called:
> 
> gpib: cb7210: Fix region leak when request_irq fails
> 
> in linux-next that came from char-misc-next. Patch [1] introduces double 
> release_region (if cb_isa_attach fails, cb_isa_detach is called and it already
> takes care of cleanup) and patch [2] introduces release_region on region we
> never obtained.
> 
> cb_isa_attach is set as attach and cb_isa_detach is set as detach in
> cb_isa_(un)accel_interface and cb_isa_interface. The only place where I see
> attach is called, is in common/iblib.c, in ibonline function. If attach fails
> there, detach is called, where a proper cleanup is performed (and it includes
> things like nec7210_board_reset for cb7120). AFAIK, the same approach is used
> for the rest of gpib.
> 
> Please revert these patches.
> 
> Additionally, patch [2] was cc'd to stable@xxxxxxxxxxxxxxx - hence adding it
> to cc for this email as well.
> 
> Thanks,
> Dominik Karol
> 
> 
> [1] https://patch.msgid.link/20260503093036.283546-1-zenghongling@xxxxxxxxxx
> [2] https://patch.msgid.link/20260518022939.16881-1-zenghongling@xxxxxxxxxx
> 

Now reverted