Re: [PATCH 1/6] sched/proxy: Remove superfluous clear_task_blocked_in()
From: John Stultz
Date: Fri May 29 2026 - 22:56:56 EST
On Fri, May 29, 2026 at 3:46 AM K Prateek Nayak <kprateek.nayak@xxxxxxx> wrote:
> On 5/29/2026 2:17 PM, Peter Zijlstra wrote:
> > Egads, this is terrible. This means all is_blocked tasks always end up
> > taking blocked_lock.
> >
> > The other suggestion (in the other subthread) was to simply delay this
> > patch until the end. That seems far more sensible.
> >
> > Anyway, let me go try and find your git tree and see what you ended up> with.
>
> Now that I look at this again, yeah, you can simply move that
> optimization later too. Github isn't letting me push the branch but
> essentially you move:
>
> e2ff8b7bde07 sched/proxy: Only return migrate when needed
> 1b89b7b21bf5 sched/proxy: Remove superfluous clear_task_blocked_in()
>
> to happen after commit a8be1edac5a1 ("sched/proxy: Remove
> PROXY_WAKING").
>
Yeah, just to confirm in my testing of the current peterz/sched/proxy
branch, I agree it looks like pushing the
"sched/proxy: Only return migrate when needed"
to be after
"sched/proxy: Remove PROXY_WAKING"
avoids some of the WARN_ONs I can trip inbetween those two currently.
thanks
-john