Re: [PATCH] host1x: bus: Fix missing ops null check in error teardown

[Thierry Reding]

On Sun, May 17, 2026 at 12:04:56PM -0500, shayderrr wrote:
> In host1x_device_init(), the error teardown paths do not check
> client->ops before dereferencing it, unlike the forward init paths
> which correctly guard with 'client->ops &&'. This can result in a
> NULL pointer dereference if client->ops is NULL.
> 
> Fix by adding the missing client->ops check in both the teardown
> and teardown_late labels.
> 
> Signed-off-by: shayderrr <darknessshayder@xxxxxxxxx>
> ---
>  drivers/gpu/host1x/bus.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I don't think this can ever happen because all clients do implement the
ops structure, but since we have them in the code above, makes sense to
be consistent.

Applied, thanks.

Thierry

Attachment: signature.asc
Description: PGP signature