RE: [PATCH v1] dmaengine: dw-edma: Add Xilinx CPM6 DMA Device ID

[Verma, Devendra]

AMD General

Hi All

Please ignore this patch. This patch has some issues that's why withdrawing it. Will submit a new patch.

NACKed by Devendra K Verma <devendra.verma@xxxxxxx>

Regards,
Devendra

> -----Original Message-----
> From: Devendra K Verma <devendra.verma@xxxxxxx>
> Sent: Thursday, May 28, 2026 15:42
> To: bhelgaas@xxxxxxxxxx; mani@xxxxxxxxxx; vkoul@xxxxxxxxxx;
> Frank.Li@xxxxxxxxxx
> Cc: dmaengine@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Simek, Michal
> <michal.simek@xxxxxxx>; Verma, Devendra <Devendra.Verma@xxxxxxx>
> Subject: [PATCH v1] dmaengine: dw-edma: Add Xilinx CPM6 DMA Device ID
>
> From: Devendra K Verma <devverma@xxxxxxx>
>
> Add Device ID for Xilinx CPM6 DMA IP.
> This IP enables 64 Read and 64 Write Channels.
>
> Adding the relevant dw_edma_pcie_data to use all the
> 64 Read and 64 Write Channels.
>
> Signed-off-by: Devendra K Verma <devendra.verma@xxxxxxx>
> ---
>  drivers/dma/dw-edma/dw-edma-pcie.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-
> edma/dw-edma-pcie.c
> index 0b30ce138503..c5e041142869 100644
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
> @@ -27,6 +27,7 @@
>
>  /* AMD MDB (Xilinx) specific defines */
>  #define PCI_DEVICE_ID_XILINX_B054            0xb054
> +#define PCI_DEVICE_ID_XILINX_B00F            0xb00f
>
>  #define DW_PCIE_XILINX_MDB_VSEC_DMA_ID               0x6
>  #define DW_PCIE_XILINX_MDB_VSEC_ID           0x20
> @@ -125,6 +126,19 @@ static const struct dw_edma_pcie_data
> xilinx_mdb_data = {
>       .rd_ch_cnt                      = 8,
>  };
>
> +static const struct dw_edma_pcie_data xilinx_cpm6_dma_data = {
> +     /* MDB registers location */
> +     .rg.bar                         = BAR_0,
> +     .rg.off                         = SZ_4K,        /*  4 Kbytes */
> +     .rg.sz                          = SZ_8K,        /*  8 Kbytes */
> +
> +     /* Other */
> +     .mf                             = EDMA_MF_HDMA_NATIVE,
> +     .irqs                           = 1,
> +     .wr_ch_cnt                      = 64,
> +     .rd_ch_cnt                      = 64,
> +};
> +
>  static void dw_edma_set_chan_region_offset(struct dw_edma_pcie_data
> *pdata,
>                                          enum pci_barno bar, off_t start_off,
>                                          off_t ll_off_gap, size_t ll_size, @@ -
> 547,6 +561,8 @@ static const struct pci_device_id dw_edma_pcie_id_table[]
> = {
>       { PCI_DEVICE_DATA(SYNOPSYS, EDDA, &snps_edda_data) },
>       { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B054),
>         (kernel_ulong_t)&xilinx_mdb_data },
> +     { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B00F),
> +       (kernel_ulong_t)&xilinx_cpm6_dma_data },
>       { }
>  };
>  MODULE_DEVICE_TABLE(pci, dw_edma_pcie_id_table);
> --
> 2.43.0