RE: [PATCH v2 2/7] pinctrl: renesas: rzg2l: Drop defines present in struct rzg2l_hwcfg

[Biju Das]

Hi Claudiu Beznea,

Thanks for the patch.

> -----Original Message-----
> From: Claudiu Beznea <claudiu.beznea@xxxxxxxxxx>
> Sent: 28 May 2026 09:05
> Subject: [PATCH v2 2/7] pinctrl: renesas: rzg2l: Drop defines present in struct rzg2l_hwcfg
> 
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> 
> Drop the QSPI and OTHER_POC register defines, which are SoC specific and accessible through struct
> rzg2l_hwcfg::{qspi, other_poc}.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> ---
> 
> Changes in v2:
> - none
> 
>  drivers/pinctrl/renesas/pinctrl-rzg2l.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> index a648d75a2bd2..77443cf1f431 100644
> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -180,8 +180,6 @@
>  #define SMT(off)		(0x3400 + (off) * 8)
>  #define SD_CH(off, ch)		((off) + (ch) * 4)
>  #define ETH_POC(off, ch)	((off) + (ch) * 4)
> -#define QSPI			(0x3008) /* known on RZ/{G2L,G2LC,G2UL,Five} only */
> -#define OTHER_POC		(0x3028) /* known on RZ/G3L only */
> 
>  #define PVDD_2500		2	/* I/O domain voltage 2.5V */
>  #define PVDD_1800		1	/* I/O domain voltage <= 1.8V */
> @@ -3816,9 +3814,9 @@ static const struct rzg2l_hwcfg rzg2l_hwcfg = {
>  	.regs = {
>  		.pwpr = 0x3014,
>  		.sd_ch = 0x3000,
> +		.qspi = 0x3008,
>  		.eth_poc = 0x300c,
>  		.oen = 0x3018,
> -		.qspi = QSPI,

Any reason for moving the assignment?

struct rzg2l_register_offsets {
	u16 pwpr;
	u16 sd_ch;
	u16 eth_poc;
	u16 oen;
	u16 qspi;
	u16 other_poc;
};

Cheers,
Biju

>  	},
>  	.iolh_groupa_ua = {
>  		/* 3v3 power source */
> @@ -3835,7 +3833,7 @@ static const struct rzg2l_hwcfg rzg3l_hwcfg = {
>  		.sd_ch = 0x3004,
>  		.eth_poc = 0x3010,
>  		.oen = 0x3018,
> -		.other_poc = OTHER_POC,
> +		.other_poc = 0x3028,
>  	},
>  	.masks = {
>  		.other_poc_pvdd1833_oth_awo_poc = BIT(0),
> --
> 2.43.0
>