Re: [PATCH v2 1/2] ALSA: usb-audio: Add QUIRK_FLAG_MIXER_GET_CUR_BROKEN

From: Takashi Iwai

Date: Thu May 28 2026 - 03:44:36 EST


On Wed, 27 May 2026 20:56:27 +0200,
Rong Zhang wrote:
>
> @@ -1258,6 +1261,16 @@ static int check_sticky_volume_control(struct usb_mixer_elem_info *cval,
> return 0;
> }
>
> + if (cval->head.mixer->chip->quirk_flags & QUIRK_FLAG_MIXER_GET_CUR_BROKEN) {
> + usb_audio_warn(cval->head.mixer->chip,
> + "%d:%d: broken mixer GET_CUR (%d/%d/%d => %d)\n",
> + cval->head.id, mixer_ctrl_intf(cval->head.mixer),
> + cval->min, cval->max, cval->res, saved);
> +

IMO, it's better to be usb_audio_info(). Otherwise it leads to an
unnecessary caution. Basically the behavior is expected, so there is
nothing to worry about that.


thanks,

Takashi