Re: [PATCH net-next v2 03/10] net: ethernet: oa_tc6: add OA_TC6_BROKEN_PHY quirk flag

[Andrew Lunn]

> To avoid extending the oa_tc6_init() signature for each new option,
> convert it to take a config struct. Update lan865x and the framework
> documentation accordingly.

We are talking about quirks here. I would prefer you add a new
parameter to oa_tc6_init() which contains these quirks, and leave the
existing parameters alone. It should probably be a structure, with a
flags member. That makes it easier to add other members in the future.

lan865x can pass a NULL, since so far they have avoided breaking the
standard, they don't need any quirks.

	Andrew