Re: [PATCH v6 0/2] Pinefeat cef168 lens control board driver

[Aliaksandr Smirnou]

On Wed, 27 May 2026 12:45:26 +0100, Alen Karnil wrote:

> > Could you provide the build error logs and the overlay files generated
> > by the tool before you modified them?
> using the configure.sh tool with imx477
> imx477_378-overlay.dtsi
> ...

The files generated after running the configure.sh tool look correct and
match mine exactly.

> If put these into my kernel build I get:
> 
> $ make dtbs
>    DTCO     arch/arm64/boot/dts/overlays/camera-mux-2port.dtbo
> arch/arm64/boot/dts/overlays/imx477_378.dtsi:26.20-31.3: ERROR 
> (duplicate_label): /fragment@200/__overlay__/pca@70/i2c@1/cef168@d: 
> Duplicate label 'vcm_node' on 
> /fragment@200/__overlay__/pca@70/i2c@1/cef168@d and 
> /fragment@200/__overlay__/pca@70/i2c@0/cef168@d
> ERROR: Input tree has errors, aborting (use -f to force output)
> make[3]: *** [scripts/Makefile.dtbs:142: 
> arch/arm64/boot/dts/overlays/camera-mux-2port.dtbo] Error 2
> make[2]: *** [scripts/Makefile.build:544: arch/arm64/boot/dts/overlays] 
> Error 2
> make[1]: *** [/home/admin/linux/Makefile:1498: dtbs] Error 2
> make: *** [Makefile:248: __sub-make] Error 2

It looks like a different Makefile is being used. In the cef168
repository's Makefile, there is no dtbs target. Also, our Makefile is
only 27 lines long, while the log output indicates the error occurs at
line 1498.

Could you please ensure you are using the Makefile provided in the cef168
repository?

> >> there needs to be some further discussions on how we could
> >> improve the user experience when it comes to enabling the vcm with
> >> camera sensors.
> > 
> > I agree. I started the discussion on the Raspberry Pi forum, but the
> > driver needs to be merged first before moving forward with that.
> Sure that makes sense, lets focus on the driver for now.
> > 
> > https://forums.raspberrypi.com/viewtopic.php?p=2318070#p2318070
> 
> Also you will most likely need to update the patch since the line 
> offsets have moved to work 6.18

Will do. Should I update the patch before or after your review?