Re: [PATCH 1/4] ACPI: video: Do not initialise device_id_scheme

From: Rafael J. Wysocki

Date: Wed May 27 2026 - 08:15:47 EST


On Sun, May 10, 2026 at 4:48 AM Jean-Ralph Aviles
<jeanralph.aviles@xxxxxxxxx> wrote:
>
> Reported by checkpatch:
>
> ERROR: do not initialise statics to false
> Signed-off-by: Jean-Ralph Aviles <jeanralph.aviles@xxxxxxxxx>
> ---
> drivers/acpi/acpi_video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
> index 05793ddef787..e8880a2113cb 100644
> --- a/drivers/acpi/acpi_video.c
> +++ b/drivers/acpi/acpi_video.c
> @@ -63,7 +63,7 @@ MODULE_PARM_DESC(hw_changes_brightness,
> * Whether the struct acpi_video_device_attrib::device_id_scheme bit should be
> * assumed even if not actually set.
> */
> -static bool device_id_scheme = false;
> +static bool device_id_scheme;
> module_param(device_id_scheme, bool, 0444);
>
> static int only_lcd;
> --

Applied as 7.2 material (with adjusted subject and changelog).

The rest of the series has not been applied because they are minor
cleanups that I would do differently.

Generally speaking, checkpatch is for new code.

Thanks!