Re: [PATCH v3 1/2] selftests/mm: refactor pkey test helpers and unify assertions

From: Mike Rapoport

Date: Wed May 27 2026 - 07:37:00 EST


Hi,

On Wed, May 27, 2026 at 09:38:24AM +0800, Hongfu Li wrote:
> Move shared tracing and assertion helpers to a common file, then
> convert the sighandler test to use pkey_assert() for consistent
> diagnostic output, and add per-test tracing around test execution.

This sounds like three patches to me.

> Signed-off-by: Hongfu Li <lihongfu@xxxxxxxxxx>
> ---
> tools/testing/selftests/mm/pkey-helpers.h | 5 +-
> .../selftests/mm/pkey_sighandler_tests.c | 108 +++++++++---------
> tools/testing/selftests/mm/pkey_util.c | 81 +++++++++++++
> tools/testing/selftests/mm/protection_keys.c | 82 -------------
> 4 files changed, 137 insertions(+), 139 deletions(-)

--
Sincerely yours,
Mike.