Re: [PATCH] block: blk-mq: fix ws_active refcount leak in blk_mq_mark_tag_wait()
From: Bart Van Assche
Date: Tue May 26 2026 - 13:18:39 EST
On 5/26/26 3:37 AM, Wentao Liang wrote:
blk_mq_mark_tag_wait() calls sbitmap_queue_get()
I don't see any sbitmap_queue_get() calls in blk_mq_mark_tag_wait().
Additionally, I don't see any other code above the modified code in
blk_mq_mark_tag_wait() that modifies sbq->ws_active directly or
indirectly. What am I missing?
Fix this by calling sbitmap_queue_clear() to properly release the
ws_active reference before returning on the error path.
This patch doesn't add a sbitmap_queue_clear() call. It seems like
there is a mismatch between the patch description and the code changes?
Bart.