Re: [PATCH v2] counter: ti-eqep: balance pm_runtime on devm_clk_get_enabled() failure

[Joshua Crofts]

On Mon, 25 May 2026 at 17:21, Stepan Ionichev <sozdayvek@xxxxxxxxx> wrote:
>
> ti_eqep_probe() calls pm_runtime_enable() and pm_runtime_get_sync()
> before devm_clk_get_enabled(). If the clk call fails, the function
> returns directly via dev_err_probe(), leaving runtime PM enabled
> and the usage counter incremented.
>
> Route the clk error through the same err_pm cleanup as counter_add()
> so the runtime PM state is unwound on every failure path.
>
> Fixes: f213729f6796 ("counter: new TI eQEP driver")
> Signed-off-by: Stepan Ionichev <sozdayvek@xxxxxxxxx>
> ---
> v2:
> - Collapse the dev_err_probe()+assignment pair into a single line
>   using its return value (Maxwell)
> - Add Fixes tag
>
> v1: https://lore.kernel.org/all/20260523184448.7609-1-sozdayvek@xxxxxxxxx/
>
>  drivers/counter/ti-eqep.c | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/counter/ti-eqep.c b/drivers/counter/ti-eqep.c
> index d21c157e5..4f3b17939 100644
> --- a/drivers/counter/ti-eqep.c
> +++ b/drivers/counter/ti-eqep.c
> @@ -548,17 +548,21 @@ static int ti_eqep_probe(struct platform_device *pdev)
>         pm_runtime_get_sync(dev);
>
>         clk = devm_clk_get_enabled(dev, NULL);
> -       if (IS_ERR(clk))
> -               return dev_err_probe(dev, PTR_ERR(clk), "failed to enable clock\n");
> +       if (IS_ERR(clk)) {
> +               err = dev_err_probe(dev, PTR_ERR(clk), "failed to enable clock\n");
> +               goto err_pm;
> +       }
>
>         err = counter_add(counter);
> -       if (err < 0) {
> -               pm_runtime_put_sync(dev);
> -               pm_runtime_disable(dev);
> -               return err;
> -       }
> +       if (err < 0)
> +               goto err_pm;
>
>         return 0;
> +
> +err_pm:
> +       pm_runtime_put_sync(dev);
> +       pm_runtime_disable(dev);
> +       return err;
>  }
>
>  static void ti_eqep_remove(struct platform_device *pdev)
> --
> 2.43.0
>

Sashiko came back with some notes, however they are issues unrelated
to this patch. LGTM.

Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>

-- 
Kind regards

CJD