Re: [PATCH v1 net-next] s390/ism: Drop superflous zeros in pci_device_id array

[Alexandra Winter]

On 22.05.26 17:54, Breno Leitao wrote:
> On Fri, May 22, 2026 at 05:30:09PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
>> Subject: [PATCH v1 net-next] s390/ism: Drop superflous zeros in pci_device_id array
> 
> Nit: s/superflous/superfluous/ ?
> 
>> The .driver_data member of the struct pci_device_id array were
>> initialized by a list expressions to zero without making use of that
>> value. In this case it's better to not specify a value at all and let
>> the compiler fill in the zeros. Same for the list terminator that can
>> better be completely empty.
>>
>> This patch doesn't introduce changes to the compiled array.
> 
> True. For a `static const` aggregate, omitted members are
> zero-initialized per C99 6.7.8, so dropping the trailing `, 0` and
> collapsing `{ 0, }` to `{ }` is a no-op at the object level.
> 
>> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
> 
> Reviewed-by: Breno Leitao <leitao@xxxxxxxxxx>


Acked-by: Alexandra Winter <wintera@xxxxxxxxxxxxx>