Re: [PATCH 1/4] clk: qcom: gcc-glymur: Move EVA clocks to critical clock list

[Dmitry Baryshkov]

On 26/05/2026 09:07, Taniya Das wrote:
> On 5/26/2026 11:16 AM, Dmitry Baryshkov wrote:
> > On Tue, May 26, 2026 at 10:59:44AM +0530, Taniya Das wrote:
> > > The gcc_eva_ahb_clk and gcc_eva_xo_clk branch clocks should not be
> > > registered as standalone GCC branch clocks.
> >
> > , otherwise .... what?
>
> If registered as normal branch clocks, they may be gated, which
> breaks access to the EVA clock controller during clock controller probe.

At least for the gcc_eva_ahb_clk I'd expect platforms actually reference 
that clock (as well as they do for GCC_VIDEO_AHB_CLK). For the XO clk 
it's fine as it follows other XO clocks, but please add it to the commit 
message.

--
With best wishes
Dmitry