Re: [PATCH] xen/mcelog: mark g_physinfo, ncpus and xen_mce_chrdev_device as __ro_after_init

[Juergen Gross]

On 23.05.26 15:28, Len Bao wrote:
> The 'g_physinfo' and 'ncpus' variables are initialized only during the
> init phase in the 'bind_virq_for_mce' function and never changed. So,
> mark them as __ro_after_init.
>
> The 'xen_mce_chrdev_device' variable is initialized only in the
> declaration and never changed. So, this variable could be 'const', but
> using the 'misc_register' and 'misc_deregister' functions discards the
> 'const' qualifier. Therefore, as an alternative, mark it as
> __ro_after_init.
>
> Signed-off-by: Len Bao <len.bao@xxxxxx>

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature