Re: [PATCH v1] dmaengine: dw-edma: Remove dw_edma_add_irq_mask()
From: Frank Li
Date: Sat May 23 2026 - 11:20:08 EST
On Thu, May 21, 2026 at 03:36:40PM +0530, Devendra K Verma wrote:
> Function dw_edma_add_irq_mask() is not used anywhere. The
> output of the function is not used hence it is redundant and
> can be removed safely.
> ---
Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> drivers/dma/dw-edma/dw-edma-core.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> index c2feb3adc79f..89a4c498a17b 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
> @@ -988,20 +988,12 @@ static inline void dw_edma_dec_irq_alloc(int *nr_irqs, u32 *alloc, u16 cnt)
> }
> }
>
> -static inline void dw_edma_add_irq_mask(u32 *mask, u32 alloc, u16 cnt)
> -{
> - while (*mask * alloc < cnt)
> - (*mask)++;
> -}
> -
> static int dw_edma_irq_request(struct dw_edma *dw,
> u32 *wr_alloc, u32 *rd_alloc)
> {
> struct dw_edma_chip *chip = dw->chip;
> struct device *dev = dw->chip->dev;
> struct msi_desc *msi_desc;
> - u32 wr_mask = 1;
> - u32 rd_mask = 1;
> int i, err = 0;
> u32 ch_cnt;
> int irq;
> @@ -1038,9 +1030,6 @@ static int dw_edma_irq_request(struct dw_edma *dw,
> dw_edma_dec_irq_alloc(&tmp, rd_alloc, dw->rd_ch_cnt);
> }
>
> - dw_edma_add_irq_mask(&wr_mask, *wr_alloc, dw->wr_ch_cnt);
> - dw_edma_add_irq_mask(&rd_mask, *rd_alloc, dw->rd_ch_cnt);
> -
> for (i = 0; i < (*wr_alloc + *rd_alloc); i++) {
> irq = chip->ops->irq_vector(dev, i);
> err = request_irq(irq,
> --
> 2.43.0
>