Re: [PATCH] NFSD: restart ssc_expire_umount walk after dropping nfsd_ssc_lock

From: Michael Bommarito

Date: Sat May 23 2026 - 07:03:33 EST


On Sat, May 23, 2026 at 6:55 AM Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> Comment is a bit confusing, given that you replaced
> list_for_each_entry_safe() with list_for_each_entry().

Sorry, that's left over from an earlier patch attempt that introduced
a different issue. How would this comment look?

Concurrent nfsd4_ssc_cancel_dul() can free an item while spinlock is
dropped for mntput() above, so restart the walk from the head so no
stale pointer is followed.

Thanks,
Mike