Re: [PATCH] pinctrl: pinconf-generic: fix of_node reference count leak in dt_node_to_map_pinmux

From: Markus Elfring

Date: Sat May 23 2026 - 06:12:53 EST


> of_get_parent() acquires a reference on pnode, but the reference is never
> released on any return path. Add of_node_put(pnode) in the exit label and

call?


> before the early return path.

Please avoid a bit of duplicate source code in the mentioned function implementation.

How do you think about to reconsider involved identifiers once more?
https://elixir.bootlin.com/linux/v7.1-rc4/source/drivers/pinctrl/pinconf-generic.c

Regards,
Markus