Re: [net-next PATCH v7 0/8] net: dsa: realtek: rtl8365mb: bridge offloading and VLAN support
From: Luiz Angelo Daros de Luca
Date: Sat May 23 2026 - 02:08:28 EST
> Changes in v7:
> * Patch 2 (DSA helpers):
> - switch from dsa_switch_for_each_available_port() to
> dsa_switch_for_each_port() in irq_teardown() to properly dispose
> of unused ports' mappings.
> - reorder the !cpu->enable check in setup() to run before chip
> configuration.
> - add a detailed comment explaining the limitation of the unsupported
> cascading layout.
> - expand the commit message to document the pre-existing IRQ handler
> guard and the new -EINVAL probe failure mode.
> * Patch 5 (VLAN):
> - replace br_vlan_get_pvid() with rtl8365mb_vlan_port_get_pvid(), which
> uses the HW info directly.
> - rename the existing internal static helper to
> rtl8365mb_vlan_port_get_pvid_idx() to cleanly export the new PVID
> retrieval helper.
> - add a logical guard check in rtl8365mb_vlan_pvid_port_add() to prevent
> accidental deletion of VLAN MC entries when reconfiguring an identical
> PVID.
> - removed spurious rtl8365mb_vlan.c.orig file.
> * Patch 7 (L2):
> - clarify CPU port EFID and assisted learning comment in fdb_add().
> - comment that EFID computation in mdb_add/del is for debugging only.
> * Patch 8 (bridge flags):
> - added missing '\n' in rtl8365mb_port_pre_bridge_flags() dbg message.
> - Link to v6: https://patch.msgid.link/20260521-realtek_forward-v6-0-d391bbad38c3@xxxxxxxxx
Hello Jakub,
I am addressing Sashiko's reviews as soon as they come in. Patches 4
to 7 are almost entirely dedicated to answering Sashiko's comments.
In this last cycle, the Gemini model caught two or three genuine bugs,
whereas the Opus/Claude model mostly asked for clarifications and
started raising broken comments. Gemini also raised a pre-series
possible issue that I'll investigate after this series is done.
Regards,
Luiz