Re: [PATCH v5 1/3] ASoC: codecs: lpass-wsa-macro: Switch to PM clock framework for runtime PM

[Ajay Kumar Nandam]

On 5/22/2026 8:07 PM, Konrad Dybcio wrote:
> On 5/22/26 3:17 PM, Mark Brown wrote:
> > On Fri, May 22, 2026 at 06:34:40PM +0530, Ajay Kumar Nandam wrote:
> >
> > > The driver now relies on pm_clk helpers and runtime PM instead of
> > > manually enabling and disabling macro, dcodec, mclk, npl, and fsgen
> > > clocks. Runtime suspend and resume handling is delegated to the PM
> > > core via pm_clk_suspend() and pm_clk_resume(), while existing runtime
> > > PM callbacks continue to manage regcache state.
> >
> > >   config SND_SOC_LPASS_WSA_MACRO
> > >   	depends on COMMON_CLK
> > > +	depends on PM
> > >   	select REGMAP_MMIO
> > >   	select SND_SOC_LPASS_MACRO_COMMON
> > >   	tristate "Qualcomm WSA Macro in LPASS(Low Power Audio SubSystem)"
> >
> > Shouldn't this be PM_CLK?  That's what the APIs are actually conditional
> > on, currently this will work out since PM_CLK depends on PM and HAVE_CLK
> > but the indirection leaves a window for things to break in future.
>
> Yeah, leaving it as-is sounds like a bad idea

ACK, will update in V6

Thanks
Ajay Kumar

> Konrad