Re: [PATCH v3 1/8] iio: temperature: ltc2983: Fix macro parenthesization and rename

[Jonathan Cameron]

On Fri, 22 May 2026 11:11:59 +0200
Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:

> On Thu, 21 May 2026 at 19:19, Liviu Stan <liviu.stan@xxxxxxxxxx> wrote:
> >
> > Wrap the 'chan' parameter in LTC2983_CHAN_START_ADDR() and
> > LTC2983_CHAN_RES_ADDR() with parentheses to prevent potential
> > macro argument expansion issues. Also rename LTC2983_CHAN_START_ADDR
> > to LTC2983_CHAN_ASSIGN_ADDR and LTC2983_CHAN_RES_ADDR to
> > LTC2983_RESULT_ADDR, to better reflect the datasheet names and avoid
> > them being confused as related.
> >
> > Signed-off-by: Liviu Stan <liviu.stan@xxxxxxxxxx>
> > ---  
> 
> Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
> 
I had a quick datasheet dive. The naming in there is rather
messy and to me seems inconsistent but these two names are indeed
used at least sometimes.  Along with conversion result start address
(which indexed by conversion channel)
(table 8).

So whilst I don't have a strong preference in favour of this rename
I guess it's fine.

Jonathan