Re: [PATCH v2 1/2] vdso: move offset_in_page() from linux/mm.h to vdso/page.h

[Thorsten Blum]

On Thu, May 21, 2026 at 03:56:19PM +0100, Lorenzo Stoakes wrote:
> On Thu, May 21, 2026 at 12:16:00PM +0100, Lorenzo Stoakes wrote:
> > On Thu, May 21, 2026 at 11:06:57AM +0200, Thorsten Blum wrote:
> > > Move offset_in_page() out of linux/mm.h so users that only need page
> > > offset calculations can include the lightweight vdso/page.h header
> > > instead of pulling in the large linux/mm.h.
> > >
> > > Include vdso/page.h from linux/mm.h so existing users of
> > > offset_in_page() continue to build.
> > >
> > > Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> >
> > LGTM other than dropping the include below (maybe Andrew can do it for
> > us?), so:
> >
> > Reviewed-by: Lorenzo Stoakes <ljs@xxxxxxxxxx>
> 
> TBH I'd like to withdraw this at this point.

OK

> Unless a series can be put forwards that sensibly justifies this, not some
> random change somewhere, I'd rather we not take it.

Using lib/bitmap-str.c as an example was apparently fine, but since that
is being removed, converting lib/string.c instead to use the same
idiomatic PAGE_SIZE - offset_in_page() calculation and include a
lightweight header is a "random change somewhere"?

> Also vdso/page.h is a VDSO-specific header by MAINTAINERS, offset_in_page() is
> really an mm thing so that's another reason not to move it.

Adding a new header was rejected (ok), but moving offset_in_page() to
vdso/page.h was your and David's suggestion, not mine.

Let's just drop this series as I don't think this is going anywhere.

Thanks,
Thorsten