Re: [PATCH v6 05/10] dmaengine: tegra: Use struct for register offsets

From: Thierry Reding

Date: Fri May 22 2026 - 06:15:18 EST


On Tue, Mar 31, 2026 at 03:52:58PM +0530, Akhil R wrote:
[...]
> diff --git a/drivers/dma/tegra186-gpc-dma.c b/drivers/dma/tegra186-gpc-dma.c
[...]
> @@ -181,18 +149,24 @@ struct tegra_dma_chip_data {
> unsigned int nr_channels;
> unsigned int channel_reg_size;
> unsigned int max_dma_count;
> + const struct tegra_dma_channel_regs *channel_regs;

Odd. I would've thought you'd have to predeclare the structure, but if
this builds fine, I suppose it's okay this way, too:

Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature