Re: [PATCH v2 13/69] mm/hugetlb: Refactor early boot gigantic hugepage allocation

[Muchun Song]

> On May 22, 2026, at 16:56, Mike Rapoport <rppt@xxxxxxxxxx> wrote:
> 
> On Wed, 13 May 2026 21:04:41 +0800, Muchun Song <songmuchun@xxxxxxxxxxxxx> wrote:
>> diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
>> index 558fafb82b8a..ff8c5ec831bb 100644
>> --- a/arch/powerpc/mm/hugetlbpage.c
>> +++ b/arch/powerpc/mm/hugetlbpage.c
>> @@ -104,17 +104,14 @@ void __init pseries_add_gpage(u64 addr, u64 page_size, unsigned long number_of_p
>> }
>> }
>> 
>> -static int __init pseries_alloc_bootmem_huge_page(struct hstate *hstate)
>> +static __init void *pseries_alloc_bootmem_huge_page(struct hstate *hstate)
>> {
>> struct huge_bootmem_page *m;
> 
> This can be void *m and powerpc code does not need to know about struct
> huge_bootmem_page at all and its declaration can be moved out of
> include/linux

Make sense.

> 
> Other than that
> 
> Reviewed-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>

Thanks.

Muchun.

> 
> -- 
> Sincerely yours,
> Mike.
>