Re: [PATCH V2 3/3] cpufreq: conservative: Simplify frequency limit handling

[Zhongqiu Han]

On 5/22/2026 12:19 PM, Viresh Kumar wrote:
> From: Lifeng Zheng <zhenglifeng1@xxxxxxxxxx>
>
> cs_dbs_update() performs explicit checks against policy->min/max
> before updating the target frequency. These checks are redundant as
> __cpufreq_driver_target() already clamps the requested frequency to
> the valid policy limits.
>
> Remove the unnecessary boundary checks and simplify the update logic.
>
> This also fixes an issue introduced by commit 00bfe05889e9 ("cpufreq:
> conservative: Decrease frequency faster for deferred updates"), where
> stale target comparisons could cause frequency updates to be skipped
> entirely after deferred adjustments.
>
> Closes: https://lore.kernel.org/all/20260421123545.1745998-1-zhenglifeng1@xxxxxxxxxx/
> Fixes: 00bfe05889e9 ("cpufreq: conservative: Decrease frequency faster for deferred updates")
> Signed-off-by: Lifeng Zheng <zhenglifeng1@xxxxxxxxxx>
> Co-developed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>


Thanks Viresh and Lifeng, this looks good to me.

Reviewed-by: Zhongqiu Han <zhongqiu.han@xxxxxxxxxxxxxxxx>


> ---
>   drivers/cpufreq/cpufreq_conservative.c | 12 +-----------
>   1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c
> index df01d33993d8..0b32ae28ec85 100644
> --- a/drivers/cpufreq/cpufreq_conservative.c
> +++ b/drivers/cpufreq/cpufreq_conservative.c
> @@ -103,10 +103,6 @@ static unsigned int cs_dbs_update(struct cpufreq_policy *policy)
>   	if (load > dbs_data->up_threshold) {
>   		dbs_info->down_skip = 0;
>   
> -		/* if we are already at full speed then break out early */
> -		if (requested_freq == policy->max)
> -			goto out;
> -
>   		requested_freq += freq_step;
>   		if (requested_freq > policy->max)
>   			requested_freq = policy->max;
> @@ -124,13 +120,7 @@ static unsigned int cs_dbs_update(struct cpufreq_policy *policy)
>   
>   	/* Check for frequency decrease */
>   	if (load < cs_tuners->down_threshold) {
> -		/*
> -		 * if we cannot reduce the frequency anymore, break out early
> -		 */
> -		if (requested_freq == policy->min)
> -			goto out;
> -
> -		if (requested_freq > freq_step)
> +		if (requested_freq > policy->min + freq_step)
>   			requested_freq -= freq_step;
>   		else
>   			requested_freq = policy->min;


--
Thx and BRs,
Zhongqiu Han