Re: [PATCH v5 4/4] staging: rtl8723bs: fix lines ending in parentheses in hal/sdio_halinit.c

[Greg KH]

On Thu, May 21, 2026 at 02:56:04PM +0200, Artur Ugnivenko wrote:
> Fix checkpatch warnings on lines that end in patentheses in
> hal/sdio_halinit.c.
> 
> Signed-off-by: Artur Ugnivenko <artur.ugnivenko@xxxxxx>
> ---
>  drivers/staging/rtl8723bs/hal/sdio_halinit.c | 49 ++++++++++----------
>  1 file changed, 25 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> index e6570fa2e8fd..494fb74ad44f 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> @@ -74,7 +74,7 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)
>  	rtw_write8(padapter, REG_CR, 0x00);
>  	/*  Enable MAC DMA/WMAC/SCHEDULE/SEC block */
>  	value16 = rtw_read16(padapter, REG_CR);
> -	value16 |= (
> +	value16 |=
>  		HCI_TXDMA_EN |
>  		HCI_RXDMA_EN |
>  		TXDMA_EN |
> @@ -82,8 +82,7 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)
>  		PROTOCOL_EN |
>  		SCHEDULE_EN |
>  		ENSEC |
> -		CALTMR_EN
> -	);
> +		CALTMR_EN;

The original () is ok to keep.

>  	rtw_write16(padapter, REG_CR, value16);
>  
>  	hal_btcoex_PowerOnSetting(padapter);
> @@ -188,15 +187,13 @@ static void _InitTxBufferBoundary(struct adapter *padapter)
>  	rtw_write8(padapter, REG_TDECTRL + 1, txpktbuf_bndy);
>  }
>  
> -static void _InitNormalChipRegPriority(
> -	struct adapter *Adapter,
> -	u16 beQ,
> -	u16 bkQ,
> -	u16 viQ,
> -	u16 voQ,
> -	u16 mgtQ,
> -	u16 hiQ
> -)
> +static void _InitNormalChipRegPriority(struct adapter *Adapter,
> +				       u16 beQ,
> +				       u16 bkQ,
> +				       u16 viQ,
> +				       u16 voQ,
> +				       u16 mgtQ,
> +				       u16 hiQ)

You can do better than this :)

try making it multiple variables per line.


>  {
>  	u16 value16 = (rtw_read16(Adapter, REG_TRXDMA_CTRL) & 0x7);
>  
> @@ -231,9 +228,13 @@ static void _InitNormalChipOneOutEpPriority(struct adapter *Adapter)
>  		break;
>  	}
>  
> -	_InitNormalChipRegPriority(
> -		Adapter, value, value, value, value, value, value
> -	);
> +	_InitNormalChipRegPriority(Adapter,
> +				   value,
> +				   value,
> +				   value,
> +				   value,
> +				   value,
> +				   value);

That's crazy, perhaps the function should be changed?

thanks,

greg k-h