Re: [f2fs-dev] [PATCH] f2fs: fix missing read bio submission on large folio error

From: Jaegeuk Kim

Date: Fri May 22 2026 - 00:22:45 EST


On 05/21, Chao Yu via Linux-f2fs-devel wrote:
> On 5/20/26 17:52, Wenjie Qi wrote:
> > From: Wenjie Qi <qiwenjie@xxxxxxxxxx>
> >
> > f2fs_read_data_large_folio() can keep a read bio across multiple
> > readahead folios. If a later folio hits an error before any of its
> > blocks are added to the bio, folio_in_bio is false and the current error
> > path returns immediately after ending that folio.
> >
> > This can leave the bio accumulated for earlier folios unsubmitted. Those
> > folios then never receive read completion, and readers can wait
> > indefinitely on the locked folios.
> >
> > Route errors through the common out path so any pending bio is submitted
> > before returning. Stop consuming more readahead folios once an error is
> > seen, and only wait on and clear the current folio when it was actually
> > added to the bio.
> >
>
> Cc: stable@xxxxxxxxxx
>
> > Fixes: a5d8b9d94e18 ("f2fs: fix to unlock folio in f2fs_read_data_large_folio()")
> > Signed-off-by: Wenjie Qi <qiwenjie@xxxxxxxxxx>
>
> Reviewed-by: Chao Yu <chao@xxxxxxxxxx>
>
> BTW, I can not apply the patch, can you please rebase it to last dev branch?

I applied.

>
> Thanks,
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel