Re: [PATCH v2 0/3] arm64: dts: qcom: kodiak: Enable 4-lane DP via QMP Combo PHY

[Bjorn Andersson]

On Wed, Apr 29, 2026 at 12:10:39PM +0530, Mahadevan P wrote:
> This series enables full 4-lane DisplayPort operation on SC7280/kodiak
> platforms by wiring up the QMP Combo PHY correctly and consolidating
> the DP endpoint configuration in the SoC dtsi.
> 
> Patch 1 adds mode-switch to the QMP Combo PHY node in kodiak.dtsi,
> which is required for the PHY to respond to USB-C Alternate Mode
> negotiation and switch into 4-lane DP configuration.
> 
> Patch 2 moves the data-lanes property from individual board files into
> kodiak.dtsi since the PHY-to-controller wiring is fixed in silicon.
> It also removes redundant remote-endpoint and orientation-switch
> overrides from qcs6490-rb3gen2 and qcs6490-thundercomm-rubikpi3 that
> are already covered by the SoC dtsi.
> 
> Patch 3 updates data-lanes from <0 1> to <0 1 2 3> in kodiak.dtsi now
> that mode-switch is in place, enabling the full 4-lane DP link.

Are you sure that herobrine has 4 lanes routed on the PCB?

Regards,
Bjorn

> 
> Signed-off-by: Mahadevan P <mahadevan.p@xxxxxxxxxxxxxxxx>
> ---
> Changes in v2:
> - Split single patch into 3 patches.
> - Move mode-switch and data-lanes to kodiak.dtsi instead of board
>   file (Neil Armstrong, Konrad Dybcio)
> - Remove redundant board-level endpoint and orientation-switch
>   overrides now covered by kodiak.dtsi
> - v1 received a Reviewed-by from Dmitry on the combined change;
>   that tag has been dropped pending re-review of the split.
> 
> ---
> Mahadevan P (3):
>       arm64: dts: qcom: kodiak: allow mode-switch events to reach the QMP Combo PHY
>       arm64: dts: qcom: kodiak: move dp data-lanes to SoC dtsi
>       arm64: dts: qcom: kodiak: Set up 4-lane DP
> 
>  arch/arm64/boot/dts/qcom/kodiak.dtsi                          |  2 ++
>  arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts            |  4 ----
>  arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dts         |  4 ----
>  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts                  | 11 -----------
>  arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts |  1 -
>  arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts     |  3 ---
>  arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi                |  1 -
>  7 files changed, 2 insertions(+), 24 deletions(-)
> ---
> base-commit: 452c3b1ea875276105ac90ba474f72b4cd9b77a2
> change-id: 20260420-kodiak_v2-d7a06d50db5e
> 
> Best regards,
> -- 
> Mahadevan P <mahadevan.p@xxxxxxxxxxxxxxxx>
>