RE: [PATCH net-next v2 8/9] onsemi: s2500: Add driver support for TS2500 MAC-PHY

[Selvamani Rajagopal]

> 
> This Message Is From an External Sender
> This message came from outside your organization.
> 
> > Little correction to what I said. As timestamp registers are in
> > vendor specific MMS, read/write/adjust time callbacks have to be in
> > vendor's code.
> 
> I've not read that part of the specification, so maybe i'm asking a
> dumb question:
> 
> Why are these registers in the vendor specific MMS? Is the
> specification missing something?

My wrong use of terms may be the cause for the confusion. Sorry about that. There are two kinds of registers when it comes to hardware timestamping. The registers that have the timestamp capture related registers. These are in MMS0 and therefore timestamping handling code would be in the core code.

But the registers that control the precise clock and compensate them for accuracy are in MDIO_MMD_VEND1, (MMS12 for onsemi). These registers needed for PTP callbacks (like adjfine, settime64 and gettimex64). This part would have to reside in vendor's code.

Hope it is clear now.

> 
> Andrew