Re: [PATCH] nfsd: fix posix_acl leak on SETACL decode failure
From: Chuck Lever
Date: Thu May 21 2026 - 15:39:58 EST
From: Chuck Lever <chuck.lever@xxxxxxxxxx>
On Thu, 21 May 2026 13:51:43 -0400, Jeff Layton wrote:
> nfsaclsvc_decode_setaclargs() and nfs3svc_decode_setaclargs() each
> call nfs_stream_decode_acl() twice, first for NFS_ACL and then for
> NFS_DFACL. Each successful call transfers ownership of a freshly
> allocated posix_acl into argp->acl_access or argp->acl_default. If
> the first call succeeds but the second fails, the decoder returns
> false and argp->acl_access is left dangling.
>
> [...]
Applied to nfsd-testing, thanks!
[1/1] nfsd: fix posix_acl leak on SETACL decode failure
commit: c5d94697918a13dd9cd5a288f5b3b8dbecd4a783
--
Chuck Lever <chuck.lever@xxxxxxxxxx>