Re: [PATCH] nfsd: fix dead ACL conflict guard in nfsd4_create
From: Chuck Lever
Date: Thu May 21 2026 - 13:09:27 EST
From: Chuck Lever <chuck.lever@xxxxxxxxxx>
On Thu, 21 May 2026 07:50:21 -0400, Jeff Layton wrote:
> nfsd4_create() steals create->cr_dpacl/cr_pacl into the local
> nfsd_attrs via the designated initializer, then immediately sets the
> source pointers to NULL. The subsequent conflict guard tests the
> already-nilled source fields, making it permanently dead code:
>
> if (create->cr_acl) {
> if (create->cr_dpacl || create->cr_pacl) /* always false */
>
> [...]
Applied to nfsd-testing, thanks!
[1/1] nfsd: fix dead ACL conflict guard in nfsd4_create
commit: e18fa5137111b7d2ab7002d041c05ee7c52694ef
--
Chuck Lever <chuck.lever@xxxxxxxxxx>