Re: [PATCH v2] netpoll: normalize skb->dev to the netpoll device

From: patchwork-bot+netdevbpf

Date: Thu May 21 2026 - 12:10:18 EST


Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@xxxxxxxxxx>:

On Tue, 19 May 2026 18:46:47 +0800 you wrote:
> __netpoll_send_skb() always transmits through np->dev and queues busy
> packets on np->dev->npinfo->txq, but it leaves skb->dev unchanged.
> Stacked callers such as DSA and macvlan can reach netpoll with skb->dev
> still naming the upper device while np->dev is the lower device that
> owns the netpoll state.
>
> If the skb has to be deferred, queue_process() later dequeues it from
> the lower device's txq but retries it through skb->dev. That can
> re-enter the upper ndo_start_xmit path on an already transformed skb,
> and if the upper device disappears before the lower txq drains the
> workqueue can dereference a stale skb->dev pointer.
>
> [...]

Here is the summary with links:
- [v2] netpoll: normalize skb->dev to the netpoll device
https://git.kernel.org/netdev/net/c/c367b9082194

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html