Re: [PATCH 2/2] x86/platform/geode: reference the real node of the cs5535 GPIO controller

[Dave Hansen]

On 4/29/26 05:23, Bartosz Golaszewski wrote:
> We now can access the address of the software node associated with the
> GPIO controller cell of the cs5535 MFD device. Make it the target of the
> GPIO software node references in geode-common.c. Make sure the cs5535
> driver is built-in for all boards selecting GEODE_COMMON.

This looks like a good cleanup, but the changelog has me scratching my
head a bit.

I'm not quite sure what problem this is solving. It's also a bit unusual
to have a driver depend on another not being built as a module. There's
also not really a mention of the:

	+MODULE_IMPORT_NS("CS5535");

in the changelog.

Oh, and on a minor note, it might all be more clear if the changelog was
written in imperative voice and removed the "We".

Honestly, this is old hardware so I don't want to fret about this too
much. I'd be happy to ack this, but I don't really know what I'm acking. ;)