Re: [PATCH v9 2/2] drm: Send per-connector hotplug events

[Daniel Stone]

Hi,

On Wed, 22 Apr 2026 at 19:24, Nicolas Frattaroli
<nicolas.frattaroli@xxxxxxxxxxxxx> wrote:
> @@ -760,16 +760,12 @@ static void output_poll_execute(struct work_struct *work)
>         struct drm_connector *connector;
>         struct drm_connector_list_iter conn_iter;
>         enum drm_connector_status old_status;
> -       bool repoll = false, changed;
> +       bool repoll = false, changed = false;
>         u64 old_epoch_counter;
>
>         if (!dev->mode_config.poll_enabled)
>                 return;
>
> -       /* Pick up any changes detected by the probe functions. */
> -       changed = dev->mode_config.delayed_event;
> -       dev->mode_config.delayed_event = false;
> -
>         if (!drm_kms_helper_poll) {
>                 if (dev->mode_config.poll_running) {
>                         drm_kms_helper_disable_hpd(dev);
> @@ -844,8 +841,15 @@ static void output_poll_execute(struct work_struct *work)
>         mutex_unlock(&dev->mode_config.mutex);
>
>  out:
> +       /* Pick up any changes detected by the probe functions. */
> +       if (dev->mode_config.delayed_event) {

Not your doing, as it was just the same before, but doesn't this read
need to be protected by the mode_config mutex?

The series is very satisfying otherwise; both patches are:
Reviewed-by: Daniel Stone <daniels@xxxxxxxxxxxxx>

Cheers,
Daniel