Re: [PATCH] lib/vsprintf: replace min_t/max_t with min/max
From: Petr Mladek
Date: Thu May 21 2026 - 10:54:21 EST
On Mon 2026-05-18 14:31:47, Thorsten Blum wrote:
> Use the simpler min()/max() macros since the values are all compatible.
>
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -1208,7 +1208,7 @@ char *hex_string(char *buf, char *end, u8 *addr, struct printf_spec spec,
> }
>
> if (spec.field_width > 0)
> - len = min_t(int, spec.field_width, 64);
> + len = min(spec.field_width, 64);
Honestly, I do not see any big advantage in replacing the macros.
In fact, the min()/max() macros are even more complex because
they check compatibility of the compared types.
IMHO, this adds non-necessary churn into the git history without
an obvious advantage.
Best Regards,
Petr