Re: (subset) [PATCH 0/4] power: sys-off: fix Pixel C shutdown via MAX77620

[Diogo Ivo]

On 5/21/26 12:41, Lee Jones wrote:
> On Thu, 21 May 2026, Diogo Ivo wrote:
>
> > Hi Lee,
> >
> > On 5/20/26 18:25, Lee Jones wrote:
> > > On Thu, 14 May 2026 16:47:18 +0200, Diogo Ivo wrote:
> > > > This series migrates PSCI and MAX77620 poweroff handling to the
> > > > sys-off framework and fixes shutdown on the Pixel C (Smaug).
> > > >
> > > > The first two patches replace legacy pm_power_off usage in the PSCI
> > > > and MAX77620 drivers with sys-off handlers. Besides aligning both
> > > > drivers with the modern poweroff infrastructure, this removes the
> > > > global callback dependency and allows multiple handlers to coexist
> > > > with explicit priorities.
> > > >
> > > > [...]
> > >
> > > Applied, thanks!
> >
> > Thanks for applying the patches! Just a question and an observation:
> >
> >   - I'm assuming you were ok with merging [2/4] despite the possible
> >     deadlock since this risk is already present in mainline in the same
> >     form so we're not actually making things worse, is that so?
>
> Did you see the text below?

Yes, but patch 3 is not addressing the possible deadlock hence my
question.

> Both patches 2 and 3 are applied.
>
> >   - The observation is that the comment about overriding PSCI is only
> >     true after (and if) a reworked [1/4] is actually merged.
> >     If it isn't then patch [3/4] is actually working around another handler
> >     in soc/tegra/pmc.c where a handler that only does work for the Nexus
> >     7 is actually registered at FIRMWARE level for all platforms that
> >     probe that driver (I will send out a patch shortly to only register
> >     the handler on the Nexus 7).
>
> I assume the other patches will be applied soon.
>
> If this causes some kind of issue - let me know later on in the cycle
> and I'll remove whatever patches you ask me to.

The PSCI patch [1/4] has a fundamental issue and needs a respin to be
applied.

In connection with this it might then become easier to quirk the PSCI
driver rather than the PMIC driver, so for the moment I'll ask you to
drop [3/4] until I propose the changes to the PSCI maintainers and see
the feedback and at that point we can either completely drop [3/4] or
reapply it; sorry for the noise.

Best regards,
Diogo