Re: [PATCH net 0/5] ethernet: 3c509: Bring driver back and make some fixes

[Maciej W. Rozycki]

On Thu, 21 May 2026, Andrew Lunn wrote:

> You need to split this up. Patches to net are likely to get back
> ported, even if they don't have Fixes tags. So please add the driver
> back in net, but fixup the issues you have found in net-next.

 Sure.

> There is also an question of if we want the coding style patch or not.
> 
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
> 
>   1.7.4. Clean-up patches
> 
>   Netdev discourages patches which perform simple clean-ups, which are
>   not in the context of other work. For example:
> 
>   * Addressing checkpatch.pl, and other trivial coding style warnings
> 
> The problem with these sorts of patches is that they often break
> stuff. This driver has been stable for a long time. Do we care about
> coding style issues enough that we are happy to possibly break it? Do
> we want to spend time on debugging it? Probably more time than it took
> to fix the checkpatch issues?

 The cleanup was requested by Jakub; since you're both maintainers for 
this stuff would you please sort this out between you two?

 As I noted in the discussion referred I'm fine either way, and especially 
now that I've gone through the effort.  Overall I'm not a great enthusiast 
of such cleanups, as mentioned there in the context of the defxx driver, 
which IMO suffers from much worse coding style issues.  I'm even less an 
enthusiast of folding the cleanup into the revert, as it's a recipe asking 
for stuff to be missed.  Plus I do consider it important for 2/5 to apply 
cleanly on top of the original code.

 NB as I point out in the cover letter I made sure there's been no change 
to binary code produced, so I expect no fallout, and as we discussed with 
Jakub the removal of the driver broke `git blame' anyway, so there should 
be no cost associated with the cleanup.

 So as I say, may you both please weigh in pros and cons and let me know 
of the outcome?  I'll then proceed accordingly.

  Maciej