Re: [PATCH v2 1/2] vdso: move offset_in_page() from linux/mm.h to vdso/page.h

[Thomas Gleixner]

On Thu, May 21 2026 at 10:30, David Laight wrote:
> On Thu, 21 May 2026 11:06:57 +0200
> Thorsten Blum <thorsten.blum@xxxxxxxxx> wrote:
>> +#include <vdso/page.h>
>
> That is already picked up otherwise PAGE_MASK would be undefined.
>
> The whole vdso headers is a mess.
> I moved one of the definitions (to do with bitmasks) back into its main header.
> The vdso compiled fine because all the 'normal' kernel headers get included
> in vdso builds.

Which is just wrong and we had subtle issues due to that in the
past.

VDSO is a pure user space library and just because it compiles does not
mean it is correct.

Thanks,

        tglx