Re: [PATCH 5/5] ASoC: amd: acp7x: add system and runtime PM ops

[Mark Brown]

On Thu, May 07, 2026 at 02:33:47PM -0500, Mario Limonciello wrote:
> On 5/7/26 13:11, Vijendar Mukunda wrote:

> > +static int __maybe_unused snd_acp7x_resume(struct device *dev)
> > +{
> > +	struct acp7x_dev_data *adata;
> > +	int ret;
> > +
> > +	adata = dev_get_drvdata(dev);
> > +	ret = acp_hw_init(adata, dev);
> > +	if (ret)
> > +		dev_err(dev, "ACP init failed\n");
> > +
> > +	return ret;
> > +}

> Both of snd_acp7x_runtime_resume and snd_acp7x_resume look identical. Will
> there be later code (when machine driver and IO enablement come) that makes
> them different?

> If not; then I think you can drop snd_acp7x_runtime_resume().

> If so; this makes sense to keep separately.

Not seeing any response to this question from Mario?

Attachment: signature.asc
Description: PGP signature