Re: [PATCH] staging: rtl8723bs: rename ndis_802_11_network_infrastructure enum values to uppercase

[Greg KH]

On Mon, May 11, 2026 at 08:49:30PM +0700, Cong Nguyen wrote:
> --- a/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> +++ b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> @@ -43,11 +43,11 @@ struct ndis_802_11_conf {
>  };
>  
>  enum ndis_802_11_network_infrastructure {
> -	Ndis802_11IBSS,
> -	Ndis802_11Infrastructure,
> -	Ndis802_11AutoUnknown,
> -	Ndis802_11InfrastructureMax,     /*  Not a real value, defined as upper bound */
> -	Ndis802_11APMode,
> +	NDIS_802_11_IBSS,
> +	NDIS_802_11_INFRASTRUCTURE,
> +	NDIS_802_11_AUTO_UNKNOWN,
> +	NDIS_802_11_INFRASTRUCTURE_MAX,     /*  Not a real value, defined as upper bound */
> +	NDIS_802_11_AP_MODE,
>  };

Why aren't you just using the NDIS values that the kernel already
provides for these?  Don't re-invent the wheel.

thanks,

greg k-h