Re: [PATCH] iio: light: al3010: read both ALS ADC registers again

[David Heidelberg]

On 20/05/2026 19:58, Alexander A. Klimov wrote:
> al3010_read_raw() used to read two adjacent registers
> until the driver was modernized using the regmap framework.
> That cleanup accidentally replaced the 16-bit word read
> with a single byte read. I'm reverting latter.

Good catch!

Reviewed-by: David Heidelberg <david@xxxxxxx>

Thank you. If you're at it, could you post same patch for the al3320a? Asus 
tf701t likely suffer the same issue.

David

> Fixes: 0e5e21e23dd6 ("iio: light: al3010: Implement regmap support")
> Signed-off-by: Alexander A. Klimov <grandmaster@xxxxxxxxxxxx>
> ---
>   drivers/iio/light/al3010.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c
> index 0932fa2b49fa..1800776d725e 100644
> --- a/drivers/iio/light/al3010.c
> +++ b/drivers/iio/light/al3010.c
> @@ -111,7 +111,8 @@ static int al3010_read_raw(struct iio_dev *indio_dev,
>   			   int *val2, long mask)
>   {
>   	struct al3010_data *data = iio_priv(indio_dev);
> -	int ret, gain, raw;
> +	int ret, gain;
> +	uint16_t raw;
>   
>   	switch (mask) {
>   	case IIO_CHAN_INFO_RAW:
> @@ -120,11 +121,12 @@ static int al3010_read_raw(struct iio_dev *indio_dev,
>   		 * - low byte of output is stored at AL3010_REG_DATA_LOW
>   		 * - high byte of output is stored at AL3010_REG_DATA_LOW + 1
>   		 */
> -		ret = regmap_read(data->regmap, AL3010_REG_DATA_LOW, &raw);
> +		ret = regmap_bulk_read(data->regmap, AL3010_REG_DATA_LOW,
> +				       &raw, sizeof(raw));
>   		if (ret)
>   			return ret;
>   
> -		*val = raw;
> +		*val = le16_to_cpu(raw);
>   
>   		return IIO_VAL_INT;
>   	case IIO_CHAN_INFO_SCALE:

--
David Heidelberg