Re: [PATCH] net: stmmac: mmc: Remove duplicate mmc_rx crc

[Andrew Lunn]

On Wed, May 20, 2026 at 02:25:12PM +0000, Abid Ali via B4 Relay wrote:
> From: Abid Ali <dev.taqnialabs@xxxxxxxxx>
> 
> Double read of mmc_rx_crc_error in XGMAC is removed.

The commit message should explain "Why?". I can read the code add see
what the patch does.

Why remove the double read? Why is this safe to do? This is hardware,
maybe it has latches values? Or clear on read? Maybe two reads are
required? So the Why? Is very important, more important than the code
change itself.

    Andrew

---
pw-bot: cr