Re: [PATCH] cpufreq: conservative: Fix incorrect frequency decrease due to stale target

From: Rafael J. Wysocki

Date: Wed May 20 2026 - 07:22:52 EST


On Wed, May 20, 2026 at 11:57 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
> On 20-05-26, 16:22, zhenglifeng (A) wrote:
> > For CPUFREQ_NEED_UPDATE_LIMITS drivers, dropping this early-exit checks
> > means cpufreq_driver->target() will always be called every time when
> > cs_dbs_update() is called. Is it OK?
>
> What about merging this change and implementing something like
> limits_changed for the policy, which can be checked for
> CPUFREQ_NEED_UPDATE_LIMITS drivers ? The variable will be updated
> whenever policy min/max changes.
>
> Rafael, that should be good for CPUFREQ_NEED_UPDATE_LIMITS drivers ?

Yes, it should AFAICS.