Re: [PATCH 1/2] dt-bindings: remoteproc: Document IPQ9650 Compute DSP

[Krzysztof Kozlowski]

On Wed, May 20, 2026 at 12:56:17AM +0530, Vignesh Viswanathan wrote:
> Add device tree binding documentation for the Qualcomm IPQ9650 CDSP
> Peripheral Authentication Service (PAS). Unlike existing PAS
> implementations, the IPQ9650 CDSP does not require power domains or an XO
> clock, requiring a separate binding.

You still need to reference common bindings, to get common properties
like smem-states.

Especially that you wrote this binding like it was including that ref.


> 
> Signed-off-by: Vignesh Viswanathan <vignesh.viswanathan@xxxxxxxxxxxxxxxx>
> ---
>  .../bindings/remoteproc/qcom,ipq9650-pas.yaml      | 136 +++++++++++++++++++++
>  1 file changed, 136 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,ipq9650-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,ipq9650-pas.yaml
> new file mode 100644
> index 000000000000..58b3a9352d87
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,ipq9650-pas.yaml
> @@ -0,0 +1,136 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/remoteproc/qcom,ipq9650-pas.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm IPQ9650 Peripheral Authentication Service
> +
> +maintainers:
> +  - Vignesh Viswanathan <vignesh.viswanathan@xxxxxxxxxxxxxxxx>
> +
> +description:
> +  Qualcomm IPQ9650 SoC Peripheral Authentication Service loads and boots
> +  firmware on the Qualcomm CDSP Hexagon core.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,ipq9650-cdsp-pas
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 6
> +
> +  interrupt-names:
> +    maxItems: 6
> +
> +  memory-region:
> +    items:
> +      - description: Memory region for main Firmware authentication
> +      - description: Memory region for Devicetree Firmware authentication
> +
> +  firmware-name:
> +    items:
> +      - description: Firmware name of the Hexagon core
> +      - description: Firmware name of the Hexagon Devicetree
> +
> +  qcom,smem-states:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    description: States used by the AP to signal the Hexagon core
> +    items:
> +      - description: Stop the modem
> +
> +  qcom,smem-state-names:
> +    description: The names of the state bits used for SMP2P output
> +    items:
> +      - const: stop
> +
> +  glink-edge:
> +    $ref: /schemas/remoteproc/qcom,glink-edge.yaml#
> +    description:
> +      Qualcomm G-Link subnode which represents communication edge, channels
> +      and devices related to the CDSP.
> +    unevaluatedProperties: false
> +
> +  smd-edge: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-names
> +  - memory-region
> +  - qcom,smem-states
> +  - qcom,smem-state-names
> +
> +allOf:
> +  - if:

Pointless. Why do you need if? There are no other devices.

Best regards,
Krzysztof