RE: [PATCH] thermal: renesas: rzg3e: Drop stale syscon documentation

From: Biju Das

Date: Wed May 20 2026 - 06:12:54 EST


Hi Prabhakar,

> -----Original Message-----
> From: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
> Sent: 20 May 2026 11:08
> Subject: Re: [PATCH] thermal: renesas: rzg3e: Drop stale syscon documentation
>
> Hi Biju,
>
> On Wed, May 20, 2026 at 10:38 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> >
> > Hi Geert,
> >
> > > -----Original Message-----
> > > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > > Sent: 20 May 2026 10:24
> > > Subject: Re: [PATCH] thermal: renesas: rzg3e: Drop stale syscon
> > > documentation
> > >
> > > On Wed, 20 May 2026 at 11:16, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > > >
> > > > Remove the stale kernel-doc description line for the 'syscon'
> > > > member from struct rzg3e_thermal_priv.
> > > >
> > > > Signed-off-by: Lad Prabhakar
> > > > <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > >
> > > Fixes: c33edd8f936ccf2e ("thermal: renesas: rzg3e: make calibration
> > > value retrieval per-chip")
> > >
> > > If commit bf746e2a41efd986 ("thermal: renesas: rzg3e: Remove stale
> > > @trim_offset kernel-doc entry") would have had that Fixes-tag,
> > > perhaps it would have been noticed that that commit removed _two_ members?
> >
> > I posted a patch removing both the members, Somehow that patch missed
> > from the thermal patchwork [1]
> >
> > [1]
> > https://lore.kernel.org/all/20260208092848.5313-1-biju.das.jz@bp.renes
> > as.com/
> >
> Sorry I missed this. A partial change was already applied with commit
> bf746e2a41efd986 ("thermal: renesas: rzg3e: Remove stale @trim_offset kernel-doc entry"). You can take
> over this patch and send a v2.

I am ok with your patch. I just pointed out that there was a patch removing both the members.

Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

Cheers,
Biju