Re: [PATCH v2 7/8] dt-bindings: arm: qcom: Document SA8797P Ride board

[Krzysztof Kozlowski]

On 20/05/2026 09:38, Krzysztof Kozlowski wrote:
> On Tue, May 19, 2026 at 02:35:04PM +0800, Shawn Guo wrote:
>> The Nord is a new generation of SoC series from Qualcomm, and SA8797P
>> is the automotive variant of Nord. SA8797P Ride is the automotive‑grade
>> development board built on SA8797P SoC. Document the board with a fallback
>> on SA8797P and Nord compatible.
>>
>> Signed-off-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index af266d584fae..ab25323c3581 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -303,6 +303,12 @@ properties:
>>                - xiaomi,sagit
>>            - const: qcom,msm8998
>>  
>> +      - items:
>> +          - enum:
>> +              - qcom,sa8797p-ride
>> +          - const: qcom,sa8797p
> 
> We do not use model compatibles for Shikra, Eliza, Hawi, Glymur etc, so
> this is inconsistent and should be somehow explained in the commit msg.

With explanation why dedicated model compatible for Nord makes sense:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof