Re: [PATCH] serial: max310x: fix I2C-only build

[Arnd Bergmann]

On Tue, May 19, 2026, at 23:14, Hugo Villeneuve wrote:
>> now causes build failures:
>
> A few days ago i sent v2 of a patch to fix this problem:
>
> https://lore.kernel.org/all/20260515183217.3554037-1-hugo@xxxxxxxxxxx/raw
>
> Did you saw it?

Sorry I hadn't checked for other patches. I verified that your
changes are functionally the same as mine.

The one change I have that you didn't include is

>> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
>> index 811250bbbd39..b9b40e80ea81 100644
>> --- a/drivers/tty/serial/Kconfig
>> +++ b/drivers/tty/serial/Kconfig
>> @@ -323,6 +323,7 @@ config SERIAL_MAX3100
>>  config SERIAL_MAX310X
>>  	tristate "MAX310X support"
>>  	depends on SPI_MASTER || I2C
>> +	depends on I2C || !I2C
>>  	select SERIAL_CORE
>>  	select REGMAP_SPI if SPI_MASTER
>>  	select REGMAP_I2C if I2C

This is still required to avoid a link failure with
SERIAL_MAX310X=y and I2C=m. Do you want to include this in
a v3 of your patch, or should I send this separately?

       Arnd